Skip to content

Daypilot production plan - #56

Merged
ruslanmv merged 1 commit into
masterfrom
dev-v0.3.5.47
Aug 4, 2026
Merged

Daypilot production plan#56
ruslanmv merged 1 commit into
masterfrom
dev-v0.3.5.47

Conversation

@ruslanmv

@ruslanmv ruslanmv commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Stop reporting a sandbox run as an empty plan
"run hello_world.py" is answered by the deterministic short-circuit in
agentic.py: no LLM involved, one step whose file action is EXECUTE, and an
execution_plan built in pure Python for the green approval card.

The chat UI then classified that response as empty and printed "The
model returned an empty plan. Try rephrasing more concretely, or pick a
stronger model in Settings → Provider" — advice that could not possibly
help, because no model produced the plan. Its actionable-action list was
CREATE / MODIFY / DELETE, and EXECUTE was never added to it. Every
sandbox run from chat hit this, whatever the backend or the model.

  • EXECUTE joins the actionable actions, and an execution_plan is now
    actionable on its own — it is built from a resolved path in Python, so
    it cannot be a hallucination and is a stronger signal than steps.
  • The classifier moves to frontend/utils/planKind.js. It decides whether
    the user sees a working plan or a failure banner, which is too much to
    leave inline in a component that needs a browser to run.
  • PlanView counts EXECUTE, for the case where the sandbox builder
    declines a file and the green card is absent but the step is real.

tests/test_plan_kind_classifier.py runs the shipped module under node and
feeds it the real try_execute_short_circuit payload, so both sides of
the boundary are checked against each other rather than against a
hand-typed fixture. Reverting either half of the fix fails a test.

@gitguardian

gitguardian Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
30439923 Triggered Generic Password 4dee6e4 tests/test_forge_auth.py View secret
30439923 Triggered Generic Password 4dee6e4 tests/test_mcp_gateway_config.py View secret
30439923 Triggered Generic Password 4dee6e4 tests/test_mcp_gateway_config.py View secret
30439923 Triggered Generic Password 4dee6e4 tests/test_forge_auth.py View secret
30439923 Triggered Generic Password 4dee6e4 tests/test_forge_auth.py View secret
30439923 Triggered Generic Password 4dee6e4 tests/test_mcp_gateway_config.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gitpilot Ready Ready Preview Aug 4, 2026 4:10pm

@ruslanmv
ruslanmv merged commit bccf6c4 into master Aug 4, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant